Fix delegation key import/export GUN inference logic #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riyazdf
changed the title
riyazdf
changed the title
riyazdf
force-pushed
the
delegation-key-import-export
branch
2 times, most recently
from
c617fb5
to
ba2f421
Compare
Signed-off-by: Riyaz Faizullabhoy <[email protected]>
… slash Also updates a test to fix the expected vs actual values. Signed-off-by: Riyaz Faizullabhoy <[email protected]>
Signed-off-by: Riyaz Faizullabhoy <[email protected]>
riyazdf
force-pushed
the
delegation-key-import-export
branch
from
ba2f421
to
fe187a2
Compare
cyli
approved these changes
Jan 3, 2017
|
keyihebingma |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic to infer the GUN from the
pathPEM header will panic when importing an exported delegation key. This is because the path will look liketuf_keys/<KEY_ID>and this logic will attempt to shorten an empty string slice: https://github.com/docker/notary/blob/v0.4.2/utils/keys.go#L114This only affects v0.4.2 - the integration test I added here passes on master without any other code changes. Targeting a v0.4.3 hotfix, if we are to release one.
Closes #1066